-
Notifications
You must be signed in to change notification settings - Fork 3
chore: remove framework dependency and use utopia-php/servers #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated project dependencies in composer.json: replaced utopia-php/framework and duplicate fetch entries with utopia-php/servers (0.2.), utopia-php/fetch (0.5.), utopia-php/telemetry (0.2.), and utopia-php/validators (0.2.) alongside existing packages. Updated import statements in src/Queue/Job.php and src/Queue/Server.php to use Hook from Utopia\Servers instead of Utopia. Three files changed in total with minor line edits. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fef9c57 to
271bf88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@composer.json`:
- Around line 33-34: Update the composer.json dependency entry for
"utopia-php/telemetry" to use a constrained semver range instead of the wildcard
"*" (e.g., "0.2.*") so builds are reproducible and aligned with the project's
other utopia dependencies such as "utopia-php/servers" — locate the
"utopia-php/telemetry" line in composer.json and replace "*" with "0.2.*", then
run composer update or composer validate to ensure the lockfile and constraints
are consistent.
In `@src/Queue/Server.php`:
- Line 8: Add a public getInjections() method to the Utopia\Servers\Hook class
that returns the protected $injections property (mirroring the existing
getParams() / getGroups() pattern used by Server::getArguments()); implement it
as a simple public getter (same visibility and return style as
getParams/getGroups) so calls like Server::getArguments() can access the
injections array.
766ce5b to
7b89d87
Compare
Summary by CodeRabbit